Timeline: Visualize future rotations#309
Merged
Merged
Conversation
sukhwinder33445
force-pushed
the
feature/visualize-future-rotations
branch
from
054ea7f to
bb7d5a3
Compare
flourish86
requested changes
Mar 24, 2025
Contributor
flourish86
left a comment
flourish86
left a comment
There was a problem hiding this comment.
When I create future entries, the rows are somehow shifted.
It only looks right, when only the first rotation has future entries and there are additional entries, with no future entries.
Only Rotation with future entries
Broken layout
Second Rotation with future entries
Shifted row
First Rotation with future entries
This looks fine
sukhwinder33445
force-pushed
the
feature/visualize-future-rotations
branch
2 times, most recently
from
8683cb7 to
b97a4bc
Compare
sukhwinder33445
force-pushed
the
feature/visualize-future-rotations
branch
from
b97a4bc to
78cab5e
Compare
Contributor
|
As discussed offline, it already looks nice. Would be great, if you could apply the following changes:
Then it should look like this. |
sukhwinder33445
force-pushed
the
feature/visualize-future-rotations
branch
4 times, most recently
from
53a24ae to
1a598e0
Compare
sukhwinder33445
requested review from
flourish86
and removed request for
flourish86
flourish86
previously approved these changes
Apr 9, 2025
sukhwinder33445
force-pushed
the
feature/visualize-future-rotations
branch
from
1a598e0 to
13868e8
Compare
- Introduce class FutureEntry
Timeline is a separate implementation. Base grid is what it's name implies, a base implementation.
In case there are less rows than sidebar entries, the grids do not match and hence the minimum must be the amount of sidebar entries that already applies in case the overlay is empty.
If it's not an `.entry`, that's fine. But making the child one, is not. Only children of the overlay must be entries. If style rules apply, copy them over.
nilmerg
force-pushed
the
feature/visualize-future-rotations
branch
from
13868e8 to
ed9a431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #214